open-autonomous-connection/luaj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Reduce allocations per LuaClosure call #76

Closed
LobbyDivinus wants to merge 3 commits from TheoTown-Team/master into master
pull from: TheoTown-Team/master
merge into: open-autonomous-connection:master
Conversation 4 Commits 3 Files Changed 1 +73 -12
LobbyDivinus commented 2020-09-01 08:42:14 +00:00 (Migrated from github.com)
Copy Link

Every call/invoke of a LuaClosure issues creation of a new stack frame for the function execution. Since this stack is usually thrown away after execution pooling them can help to reduce garbage collection overhead (there's one exception to this: the stack can be used as part of the returned varargs object, in that case it cannot be reused since that could cause conflicts). In my use case this change was useful for calling a lot of Lua functions on mobile devices.

Every call/invoke of a LuaClosure issues creation of a new stack frame for the function execution. Since this stack is usually thrown away after execution pooling them can help to reduce garbage collection overhead (there's one exception to this: the stack can be used as part of the returned varargs object, in that case it cannot be reused since that could cause conflicts). In my use case this change was useful for calling a lot of Lua functions on mobile devices.
👍 2
wagyourtail commented 2023-11-05 14:38:21 +00:00 (Migrated from github.com)
Copy Link

this is not thread safe...
image
also, stackpool not really clearing seems leaky to me...

this is not thread safe... ![image](https://github.com/luaj/luaj/assets/6234704/bce5fe99-6aa7-43f6-ac0d-49cb20bb2596) also, stackpool not really clearing seems leaky to me...
LobbyDivinus commented 2023-11-06 09:00:15 +00:00 (Migrated from github.com)
Copy Link

To my knowledge luaj is not thread safe at all (and so is Lua itself). However, it should be fine if you make calls from different threads if they are not concurrent. If you need concurrent execution you may have to use mutliple environments.

The stackpool should be released once the associated LuaClosure gets garbage collected. Doing it earlier would hurt the intention of this PR.

To my knowledge luaj is not thread safe at all (and so is Lua itself). However, it should be fine if you make calls from different threads if they are not concurrent. If you need concurrent execution you may have to use mutliple environments. The stackpool should be released once the associated LuaClosure gets garbage collected. Doing it earlier would hurt the intention of this PR.
SquidDev commented 2023-11-06 09:56:48 +00:00 (Migrated from github.com)
Copy Link

This stack pool is per-LuaClosure, so this should be safe under LuaJ's guarantees - LuaClosures shouldn't be shared across Global instances or called from multiple threads at once.

This stack pool is per-`LuaClosure`, so this should be safe under LuaJ's guarantees - `LuaClosure`s shouldn't be shared across `Global` instances or called from multiple threads at once.
❤️ 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
open-autonomous-connection
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: open-autonomous-connection/luaj#76
Delete Branch "TheoTown-Team/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?