open-autonomous-connection/luaj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fixed LuaJC not writing java package to bytecode correctly #25

Closed
tomcashman wants to merge 1 commits from mini2Dx/master into master
pull from: mini2Dx/master
merge into: open-autonomous-connection:master
Conversation 1 Commits 1 Files Changed 2 +21 -2
tomcashman commented 2018-12-18 18:26:08 +00:00 (Migrated from github.com)
Copy Link

(Note: I encountered this issue earlier today in https://github.com/mini2Dx/miniscript/ )

LuaJC was transforming package names (e.g. org.example.ExampleClass) to class name prefixes (e.g. org_example_ExampleClass) with the default package being used. Based on the command line args, it should come out as class ExampleClass with package org.example

The following commit fixes the issue.

(Note: I encountered this issue earlier today in https://github.com/mini2Dx/miniscript/ ) LuaJC was transforming package names (e.g. `org.example.ExampleClass`) to class name prefixes (e.g. `org_example_ExampleClass`) with the default package being used. Based on the command line args, it should come out as class `ExampleClass` with package `org.example` The following commit fixes the issue.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
open-autonomous-connection
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: open-autonomous-connection/luaj#25
Delete Branch "mini2Dx/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?