open-autonomous-connection/luaj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fix build stack traceback in DebugLib #7 #11

Closed
Enyby wants to merge 3 commits from patch-4 into master
pull from: patch-4
merge into: open-autonomous-connection:master
Conversation 1 Commits 3 Files Changed 3 +30 -65
Enyby commented 2018-07-02 01:57:53 +00:00 (Migrated from github.com)
Copy Link

If create huge table with a lot items (> 28000) then additional op code for store c out of range of op codes and this loop crash.
This PR add case for OP_SETLIST for skip next op if in it stored c.
OP_SETLIST not AMode OP
70cb74b4d6/src/core/org/luaj/vm2/Lua.java (L319)
70cb74b4d6/src/core/org/luaj/vm2/Lua.java (L335)

If create huge table with a lot items (> 28000) then additional op code for store `c` out of range of op codes and this loop crash. This PR add case for OP_SETLIST for skip next op if in it stored `c`. OP_SETLIST not AMode OP https://github.com/luaj/luaj/blob/70cb74b4d65851ef69240d35b58d9f8d20a73ed1/src/core/org/luaj/vm2/Lua.java#L319 https://github.com/luaj/luaj/blob/70cb74b4d65851ef69240d35b58d9f8d20a73ed1/src/core/org/luaj/vm2/Lua.java#L335
headcr4sh commented 2018-09-13 10:03:53 +00:00 (Migrated from github.com)
Copy Link

I had to rebase the master branch onto some missing changes that never made it from CVS into Git.
This renders your PR useless, I am afraid. Could you rebase your changes onto the current master branch again, please?

I had to rebase the master branch onto some missing changes that never made it from CVS into Git. This renders your PR useless, I am afraid. Could you rebase your changes onto the current master branch again, please?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
open-autonomous-connection
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: open-autonomous-connection/luaj#11
Delete Branch "patch-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?