Chunk name is chunked on reporting a lexer error #64

New Issue

open-autonomous-connection · 2019-12-20T23:19:42Z

noncom commented

2019-12-20 23:19:42 +00:00

(Migrated from github.com)

When you introduce some lexer error in a module source, for example accidentally input a non-english character inside the code, like a Chinese or a Cyrillic one, the lexer fails and reports the error via the https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/compiler/LexState.java#L261 method. This method tries to print the module name or path where the error occured.

However, if the path to the module is too long, it gets chopped at 80 characters because the method https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/Lua.java#L346 that is used to create the error string cuts the module name for the length specified by https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/Lua.java#L344 which is 80 characters.

This artificial limitation is not needed at all and effectively prevents seeing in what file exactly did the error occur.

My proposal is to increase the length of the string like that:

private static final int MAXSRC = Integer.MAX_VALUE;

When you introduce some lexer error in a module source, for example accidentally input a non-english character inside the code, like a Chinese or a Cyrillic one, the lexer fails and reports the error via the https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/compiler/LexState.java#L261 method. This method tries to print the module name or path where the error occured. However, if the path to the module is too long, it gets chopped at 80 characters because the method https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/Lua.java#L346 that is used to create the error string cuts the module name for the length specified by https://github.com/luaj/luaj/blob/master/src/core/org/luaj/vm2/Lua.java#L344 which is 80 characters. This artificial limitation is not needed at all and effectively prevents seeing in what file exactly did the error occur. My proposal is to increase the length of the string like that: private static final int MAXSRC = Integer.MAX_VALUE;

open-autonomous-connection closed this issue

2026-03-02 13:48:57 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: open-autonomous-connection/luaj#64