tonumber("-") returns 0 #6

New Issue

open-autonomous-connection · 2018-03-14T02:01:03Z

technomancy commented

2018-03-14 02:01:03 +00:00

(Migrated from github.com)

It should return nil.

noncom commented

2019-06-04 20:21:21 +00:00

(Migrated from github.com)

Confirming. This, for example, breaks https://github.com/bakpakin/Fennel

The fix that I am using is in the base method of LuaString.scanlong():

private double scanlong( int base, int start, int end ) {
	long x = 0;
	boolean neg = (m_bytes[start] == '-');
        // --- fix starts here ---
	if(neg && m_bytes.length == 1) {
		return Double.NaN; // this is only a '-' sign, no parsing any number is required
	}
        // --- fix ends here ---
	for ( int i=(neg?start+1:start); i<end; i++ ) {
		int digit = m_bytes[i] - (base<=10||(m_bytes[i]>='0'&&m_bytes[i]<='9')? '0':
				m_bytes[i]>='A'&&m_bytes[i]<='Z'? ('A'-10): ('a'-10));
		if ( digit < 0 || digit >= base )
			return Double.NaN;		
		x = x * base + digit;
		if ( x < 0 )
			return Double.NaN; // overflow
	}
	return neg? -x: x;
}

Can this be considered a good fix for this?

Confirming. This, for example, breaks https://github.com/bakpakin/Fennel The fix that I am using is in the base method of `LuaString.scanlong()`: private double scanlong( int base, int start, int end ) { long x = 0; boolean neg = (m_bytes[start] == '-'); // --- fix starts here --- if(neg && m_bytes.length == 1) { return Double.NaN; // this is only a '-' sign, no parsing any number is required } // --- fix ends here --- for ( int i=(neg?start+1:start); i<end; i++ ) { int digit = m_bytes[i] - (base<=10||(m_bytes[i]>='0'&&m_bytes[i]<='9')? '0': m_bytes[i]>='A'&&m_bytes[i]<='Z'? ('A'-10): ('a'-10)); if ( digit < 0 || digit >= base ) return Double.NaN; x = x * base + digit; if ( x < 0 ) return Double.NaN; // overflow } return neg? -x: x; } Can this be considered a good fix for this?

open-autonomous-connection referenced this issue from a commit

2026-03-01 17:47:31 +00:00

Fixed issue: tonumber("-") returns 0 #6

open-autonomous-connection commented

2026-03-01 17:47:34 +00:00

Fixed

open-autonomous-connection closed this issue

2026-03-01 17:47:34 +00:00

Sign in to join this conversation.