Comparing doubles often fails #47

New Issue

open-autonomous-connection · 2019-08-10T18:50:05Z

orange451 commented

2019-08-10 18:50:05 +00:00

(Migrated from github.com)

Comparing double values using luaj often fails, since it uses a simple comparison. See:
https://howtodoinjava.com/java/basics/correctly-compare-float-double/

Would something like this be possible to be put into the current version of LuaJ?

For example, I'm keeping track of how a variable changes in my program. I set the player height to 1.0. In the next frame I set his height to 1.0 again. On height change, I check the current value of height in the lua object (which should be 1.0 but it's now 0.999999999). 0.9999999 is not equal to 1.0, so it thinks the player height changed. Sure I can work around this, but I have a few thousand variables being checked, and would rather not change them all like this.

Comparing double values using luaj often fails, since it uses a simple comparison. See: https://howtodoinjava.com/java/basics/correctly-compare-float-double/ Would something like this be possible to be put into the current version of LuaJ? For example, I'm keeping track of how a variable changes in my program. I set the player height to 1.0. In the next frame I set his height to 1.0 again. On height change, I check the current value of height in the lua object (which should be 1.0 but it's now 0.999999999). 0.9999999 is not equal to 1.0, so it thinks the player height changed. Sure I can work around this, but I have a few thousand variables being checked, and would rather not change them all like this.

open-autonomous-connection commented

2026-03-02 14:31:23 +00:00

Fixed

open-autonomous-connection closed this issue

2026-03-02 14:31:23 +00:00

open-autonomous-connection referenced this issue from a commit

2026-03-02 14:31:32 +00:00

Fixed issue: #47

open-autonomous-connection referenced this issue from a commit

2026-03-02 14:36:16 +00:00

Implemented issue: #47

Sign in to join this conversation.