From db3e275a6acf250056e2694a8de37695d5aacdf5 Mon Sep 17 00:00:00 2001
From: James Roseborough <james.roseborough@luaj.org>
Date: Sat, 24 Apr 2010 18:09:58 +0000
Subject: [PATCH] Improve bytecode generation.

---
 src/jse/org/luaj/vm2/luajc/JavaGen.java |  2 +-
 src/jse/org/luaj/vm2/luajc/Slots.java   | 18 ++++++++----------
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/jse/org/luaj/vm2/luajc/JavaGen.java b/src/jse/org/luaj/vm2/luajc/JavaGen.java
index ce382077..b4f134de 100644
--- a/src/jse/org/luaj/vm2/luajc/JavaGen.java
+++ b/src/jse/org/luaj/vm2/luajc/JavaGen.java
@@ -338,7 +338,7 @@ public class JavaGen {
 				// a[2] = a[3] = v[1]
 				builder.createUpvalues(pc, a+3, c);
 				builder.loadVarresult();
-				builder.dup();
+				if ( c>=2 ) builder.dup();
 				builder.arg( 1 );
 				builder.dup();
 				builder.storeLocal(pc, a+2);
diff --git a/src/jse/org/luaj/vm2/luajc/Slots.java b/src/jse/org/luaj/vm2/luajc/Slots.java
index f4f2f25a..e3661810 100644
--- a/src/jse/org/luaj/vm2/luajc/Slots.java
+++ b/src/jse/org/luaj/vm2/luajc/Slots.java
@@ -201,20 +201,18 @@ public class Slots {
 				break;
 				
 			case Lua.OP_CALL: /*	A B C	R(A), ... ,R(A+C-2):= R(A)(R(A+1), ... ,R(A+B-1)) */
-				s[a] |= BIT_ASSIGN | BIT_REFER;
-				for ( int i=1; i<b; i++ )
+				for ( int i=0; i<b; i++ )
 					s[a+i] |= BIT_REFER;
-				for ( int i=1; i<c-1; i++ )
-					s[++a] |= BIT_ASSIGN;
-				while ( ++a<m )
+				for ( int i=0; i<c-1; i++, a++ )
+					s[a] |= BIT_ASSIGN;
+				for ( ; a<m; a++ )
 					s[a] |= BIT_INVALID;
 				break;
 				
 			case Lua.OP_TAILCALL: /*	A B C	return R(A)(R(A+1), ... ,R(A+B-1))		*/
-				s[a] |= BIT_REFER;
-				for ( int i=1; i<b; i++ )
-					s[++a] |= BIT_REFER;
-				while ( ++a<m )
+				for ( int i=1; i<b; i++, a++ )
+					s[a] |= BIT_REFER;
+				for ( ; a<m; a++ )
 					s[a] |= BIT_INVALID;
 				break;
 				
@@ -395,7 +393,7 @@ public class Slots {
 	}
 
 	private int lastAssignBefore(int index, int limit, int j) {
-		for ( int i=index-1; i>limit; --i )
+		for ( int i=index; i>limit; --i )
 			if ( (slots[i][j] & (BIT_ASSIGN | BIT_NIL)) != 0 )
 				return i;
 		return index;