From a8f129b8cfa80663af20c01aed15d7b8da9d2da2 Mon Sep 17 00:00:00 2001
From: James Roseborough <james.roseborough@luaj.org>
Date: Tue, 6 Apr 2010 04:55:57 +0000
Subject: [PATCH] Add string cache to pool most commonly used Java strings

---
 src/core/org/luaj/vm2/LuaString.java          | 29 +++++++++++++++++--
 .../luaj/vm2/UnaryBinaryOperatorsTest.java    |  4 +--
 2 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/src/core/org/luaj/vm2/LuaString.java b/src/core/org/luaj/vm2/LuaString.java
index 4bacc44e..3eabe7f5 100644
--- a/src/core/org/luaj/vm2/LuaString.java
+++ b/src/core/org/luaj/vm2/LuaString.java
@@ -25,8 +25,8 @@ import java.io.ByteArrayInputStream;
 import java.io.DataOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.lang.ref.WeakReference;
 
-import org.luaj.vm2.lib.MathLib;
 import org.luaj.vm2.lib.StringLib;
 
 public class LuaString extends LuaValue {
@@ -37,11 +37,36 @@ public class LuaString extends LuaValue {
 	public final int    m_offset;
 	public final int    m_length;
 
+	private static final int STRINGCACHE_POW2 = 10;
+	private static final WeakReference[] stringcache 
+					= new WeakReference[1<<STRINGCACHE_POW2];
+
+	private static class LuaJavaString extends LuaString {
+		private final String string;
+		private LuaJavaString(String value, byte[] bytes) {
+			super(bytes);
+			string = value.intern();
+		}
+		public String toString() {
+			return string;
+		}
+	}
+	
 	public static LuaString valueOf(String string) {
+		int h = string.hashCode();
+		int i = h & ((1<<STRINGCACHE_POW2)-1);
+		if ( stringcache[i] != null ) {
+			LuaJavaString s = (LuaJavaString) stringcache[i].get();
+			if ( s != null && s.string == string ) {
+				return s;
+			}
+		}
 		char[] c = string.toCharArray();
 		byte[] b = new byte[lengthAsUtf8(c)];
 		encodeToUtf8(c, b, 0);
-		return new LuaString(b);
+		LuaJavaString s = new LuaJavaString(string,b);
+		stringcache[i] = new WeakReference(s);
+		return s;
 	}
 
 	public LuaString(byte[] bytes, int offset, int length) {
diff --git a/test/junit/org/luaj/vm2/UnaryBinaryOperatorsTest.java b/test/junit/org/luaj/vm2/UnaryBinaryOperatorsTest.java
index 8bb9dd16..3195226a 100644
--- a/test/junit/org/luaj/vm2/UnaryBinaryOperatorsTest.java
+++ b/test/junit/org/luaj/vm2/UnaryBinaryOperatorsTest.java
@@ -127,7 +127,7 @@ public class UnaryBinaryOperatorsTest extends TestCase {
 		
 		// objects should be different
 		assertNotSame(ia, ib);
-		assertNotSame(sa, sb);
+		assertSame(sa, sb);
 		assertNotSame(ia, ic);
 		assertNotSame(sa, sc);
 		
@@ -148,7 +148,7 @@ public class UnaryBinaryOperatorsTest extends TestCase {
 		
 		// objects should be different
 		assertNotSame(da, db);
-		assertNotSame(sa, sb);
+		assertSame(sa, sb);
 		assertNotSame(da, dc);
 		assertNotSame(sa, sc);