From 4802623aa32c0f5c52e773c4a7b485cee2920d12 Mon Sep 17 00:00:00 2001 From: Enrico Horn Date: Sun, 11 Jul 2021 13:41:05 +0200 Subject: [PATCH] Only check return type in xpcall pass tests The error message is more specific with luaj --- .../src/test/resources/errors/baselibargs.lua | 4 +- .../test/resources/errors/jse/baselibargs.out | 72 +++++++++---------- 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/luaj-test/src/test/resources/errors/baselibargs.lua b/luaj-test/src/test/resources/errors/baselibargs.lua index 4c9e5bdf..8d72e8c7 100644 --- a/luaj-test/src/test/resources/errors/baselibargs.lua +++ b/luaj-test/src/test/resources/errors/baselibargs.lua @@ -132,8 +132,8 @@ checkallerrors('type',{},'bad argument') -- xpcall banner('xpcall') -checkallpass('xpcall', {notanil,nonfunction}) -checkallpass('xpcall', {notanil,{function(...)return 'aaa', 'bbb', #{...} end}}) +checkallpass('xpcall', {notanil,nonfunction},true) +checkallpass('xpcall', {notanil,{function(...)return 'aaa', 'bbb', #{...} end}},true) checkallerrors('xpcall',{anylua},'bad argument') diff --git a/luaj-test/src/test/resources/errors/jse/baselibargs.out b/luaj-test/src/test/resources/errors/jse/baselibargs.out index c33d242c..f944119f 100644 --- a/luaj-test/src/test/resources/errors/jse/baselibargs.out +++ b/luaj-test/src/test/resources/errors/jse/baselibargs.out @@ -482,43 +482,43 @@ true - type() ...bad argument... ====== xpcall ====== --- checkallpass -- xpcall('abc','abc') false,'error in error handling' -- xpcall(1.25,'abc') false,'error in error handling' -- xpcall(true,'abc') false,'error in error handling' -- xpcall(,'abc') false,'error in error handling' -- xpcall(,'abc') true -- xpcall(,'abc') false,'error in error handling' -- xpcall('abc',1.25) false,'error in error handling' -- xpcall(1.25,1.25) false,'error in error handling' -- xpcall(true,1.25) false,'error in error handling' -- xpcall(
,1.25) false,'error in error handling' -- xpcall(,1.25) true -- xpcall(,1.25) false,'error in error handling' -- xpcall('abc',true) false,'error in error handling' -- xpcall(1.25,true) false,'error in error handling' -- xpcall(true,true) false,'error in error handling' -- xpcall(
,true) false,'error in error handling' -- xpcall(,true) true -- xpcall(,true) false,'error in error handling' -- xpcall('abc',
) false,'error in error handling' -- xpcall(1.25,
) false,'error in error handling' -- xpcall(true,
) false,'error in error handling' -- xpcall(
,
) false,'error in error handling' -- xpcall(,
) true -- xpcall(,
) false,'error in error handling' -- xpcall('abc',) false,'error in error handling' -- xpcall(1.25,) false,'error in error handling' -- xpcall(true,) false,'error in error handling' -- xpcall(
,) false,'error in error handling' -- xpcall(,) true -- xpcall(,) false,'error in error handling' +- xpcall('abc','abc') boolean,string +- xpcall(1.25,'abc') boolean,string +- xpcall(true,'abc') boolean,string +- xpcall(
,'abc') boolean,string +- xpcall(,'abc') boolean +- xpcall(,'abc') boolean,string +- xpcall('abc',1.25) boolean,string +- xpcall(1.25,1.25) boolean,string +- xpcall(true,1.25) boolean,string +- xpcall(
,1.25) boolean,string +- xpcall(,1.25) boolean +- xpcall(,1.25) boolean,string +- xpcall('abc',true) boolean,string +- xpcall(1.25,true) boolean,string +- xpcall(true,true) boolean,string +- xpcall(
,true) boolean,string +- xpcall(,true) boolean +- xpcall(,true) boolean,string +- xpcall('abc',
) boolean,string +- xpcall(1.25,
) boolean,string +- xpcall(true,
) boolean,string +- xpcall(
,
) boolean,string +- xpcall(,
) boolean +- xpcall(,
) boolean,string +- xpcall('abc',) boolean,string +- xpcall(1.25,) boolean,string +- xpcall(true,) boolean,string +- xpcall(
,) boolean,string +- xpcall(,) boolean +- xpcall(,) boolean,string --- checkallpass -- xpcall('abc',) false,'aaa' -- xpcall(1.25,) false,'aaa' -- xpcall(true,) false,'aaa' -- xpcall(
,) false,'aaa' -- xpcall(,) true -- xpcall(,) false,'aaa' +- xpcall('abc',) boolean,string +- xpcall(1.25,) boolean,string +- xpcall(true,) boolean,string +- xpcall(
,) boolean,string +- xpcall(,) boolean +- xpcall(,) boolean,string --- checkallerrors - xpcall(nil) ...bad argument... - xpcall('abc') ...bad argument...